-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: Forward standard output to logger #2361
Conversation
The biggest issue with this approach is that we might be getting wrong compiler messages (from concurrent compilation) if compiling a couple of things at the same time. On the other hand, it would really be a rare scenario where we would get printlns from compiler at the same time for different clients as normal compilation does not do it. This should not cause real issues especially that nowadays Bloop really just works with one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't really like it but I guess we don't have a choice. It would be nice if the compiler uses the logger to print those trees.
backend/src/main/scala/sbt/internal/inc/bloop/internal/BloopHighLevelCompiler.scala
Outdated
Show resolved
Hide resolved
Good news is that with the recent changes this is only an issue if the same user compiles with additional print options two projects at the same time. Which should be super rare. |
I will merge this after 2.0.0 just to be on the safe side |
Causes VirtusLab/scala-cli#1023